chore: enable nullables for entire solution#924
chore: enable nullables for entire solution#924philasmar merged 1 commit intofeature/net8-upgradefrom
Conversation
There was a problem hiding this comment.
why these extra imports?
There was a problem hiding this comment.
After updating, ambiguous references started to show up. That's why these are needed.
There was a problem hiding this comment.
is null! a valid thing to do?
There was a problem hiding this comment.
This is used when we want to force a value to be null. It's fine to be used in certain cases. Also in the test suite it makes sense to avoid refactoring a lot and the tests would fail if anything unexpected happened.
446aeb9 to
ab115aa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/net8-upgrade #924 +/- ##
=======================================================
Coverage ? 62.34%
=======================================================
Files ? 294
Lines ? 10735
Branches ? 1562
=======================================================
Hits ? 6693
Misses ? 3483
Partials ? 559 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Issue #, if available:
DOTNET-8095
Description of changes:
Enable nullables for the entire solution
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.