Skip to content

chore: enable nullables for entire solution#924

Merged
philasmar merged 1 commit intofeature/net8-upgradefrom
asmarp/enable-nullables
May 7, 2025
Merged

chore: enable nullables for entire solution#924
philasmar merged 1 commit intofeature/net8-upgradefrom
asmarp/enable-nullables

Conversation

@philasmar
Copy link
Copy Markdown
Contributor

Issue #, if available:
DOTNET-8095

Description of changes:
Enable nullables for the entire solution

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@philasmar philasmar requested review from GarrettBeatty and normj May 5, 2025 18:58
@philasmar philasmar added the Release Not Needed Add this label if a PR does not need to be released. label May 5, 2025
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why these extra imports?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating, ambiguous references started to show up. That's why these are needed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is null! a valid thing to do?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used when we want to force a value to be null. It's fine to be used in certain cases. Also in the test suite it makes sense to avoid refactoring a lot and the tests would fail if anything unexpected happened.

Base automatically changed from asmarp/switch-to-spectre-cli to feature/net8-upgrade May 7, 2025 21:42
@philasmar philasmar force-pushed the asmarp/enable-nullables branch from 446aeb9 to ab115aa Compare May 7, 2025 21:43
@codecov
Copy link
Copy Markdown

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 7.54717% with 49 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/net8-upgrade@6287d74). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...igFileDeployment/DeploymentSettingsHandlerTests.cs 0.00% 11 Missing ⚠️
...es/Validation/OptionSettingsItemValidationTests.cs 0.00% 11 Missing ⚠️
...tTests/LocalUserSettings/LocalUserSettingsTests.cs 0.00% 5 Missing ⚠️
...tTests/Recipes/Validation/ValidatorFactoryTests.cs 0.00% 5 Missing ⚠️
...tion/ECSFargateOptionSettingItemValidationTests.cs 0.00% 3 Missing ⚠️
...loymentManifestFile/DeploymentManifestFileTests.cs 0.00% 2 Missing ⚠️
...ation/AppRunnerOptionSettingItemValidationTests.cs 0.00% 2 Missing ⚠️
...ation/BlazorWasmOptionSettingItemValidationTest.cs 0.00% 2 Missing ⚠️
...ecipes/Validation/DockerfilePathValidationTests.cs 0.00% 2 Missing ⚠️
...lasticBeanStalkOptionSettingItemValidationTests.cs 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@                   Coverage Diff                   @@
##             feature/net8-upgrade     #924   +/-   ##
=======================================================
  Coverage                        ?   62.34%           
=======================================================
  Files                           ?      294           
  Lines                           ?    10735           
  Branches                        ?     1562           
=======================================================
  Hits                            ?     6693           
  Misses                          ?     3483           
  Partials                        ?      559           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philasmar philasmar merged commit ed5f931 into feature/net8-upgrade May 7, 2025
10 checks passed
@philasmar philasmar deleted the asmarp/enable-nullables branch May 7, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release Not Needed Add this label if a PR does not need to be released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants