Skip to content

feat: update NodeJS minimum version to 18#930

Merged
philasmar merged 1 commit intofeature/net8-upgradefrom
asmarp/bump-node-min-version
May 9, 2025
Merged

feat: update NodeJS minimum version to 18#930
philasmar merged 1 commit intofeature/net8-upgradefrom
asmarp/bump-node-min-version

Conversation

@philasmar
Copy link
Copy Markdown
Contributor

Issue #, if available:
DOTNET-8095

Description of changes:
Update NodeJS minimum version to 18 since AWS CDK has dropped support for 14 and 16 https://aws.amazon.com/blogs/devops/announcing-the-end-of-support-for-node-js-14-x-and-16-x-in-aws-cdk/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@philasmar philasmar requested review from GarrettBeatty and normj May 8, 2025 17:12
@philasmar philasmar added the Release Not Needed Add this label if a PR does not need to be released. label May 8, 2025
@philasmar philasmar force-pushed the asmarp/add-support-podman branch from c7c9b32 to 352eb23 Compare May 8, 2025 18:58
@philasmar philasmar force-pushed the asmarp/bump-node-min-version branch from b12fb39 to d9c3009 Compare May 8, 2025 19:59
Base automatically changed from asmarp/add-support-podman to feature/net8-upgrade May 9, 2025 16:50
@philasmar philasmar force-pushed the asmarp/bump-node-min-version branch from d9c3009 to 3886458 Compare May 9, 2025 16:51
@codecov
Copy link
Copy Markdown

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature/net8-upgrade@fa54e10). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             feature/net8-upgrade     #930   +/-   ##
=======================================================
  Coverage                        ?   62.12%           
=======================================================
  Files                           ?      294           
  Lines                           ?    10783           
  Branches                        ?     1612           
=======================================================
  Hits                            ?     6699           
  Misses                          ?     3487           
  Partials                        ?      597           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philasmar philasmar merged commit 4ff2b78 into feature/net8-upgrade May 9, 2025
10 checks passed
@philasmar philasmar deleted the asmarp/bump-node-min-version branch May 9, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release Not Needed Add this label if a PR does not need to be released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants