Skip to content

fix: fix cross-platform issues with docker files#943

Merged
philasmar merged 3 commits intofeature/net8-upgradefrom
asmarp/fix-docker-images
Jun 5, 2025
Merged

fix: fix cross-platform issues with docker files#943
philasmar merged 3 commits intofeature/net8-upgradefrom
asmarp/fix-docker-images

Conversation

@philasmar
Copy link
Copy Markdown
Contributor

Description of changes:
Remove NodeJS from docker images since Microsoft no longer ships Angular and React templates for Web Apps. This also fixes an issue caused by a mismatch in architectures in the base images across the docker stages.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@philasmar philasmar requested review from GarrettBeatty and normj June 3, 2025 20:54
@philasmar philasmar added the Release Not Needed Add this label if a PR does not need to be released. label Jun 3, 2025
Copy link
Copy Markdown
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need a change log file for this or is that being done for the feature branch. I'm worried we will forget to call this out if we don't have something in place now?

@philasmar
Copy link
Copy Markdown
Contributor Author

Don't you need a change log file for this or is that being done for the feature branch. I'm worried we will forget to call this out if we don't have something in place now?

I was planning on adding the change file before releasing the feature branch. However, I added one to this PR so that we don't forget to call it out.

@philasmar philasmar requested a review from normj June 3, 2025 21:19
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature/net8-upgrade@4ff2b78). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             feature/net8-upgrade     #943   +/-   ##
=======================================================
  Coverage                        ?   62.12%           
=======================================================
  Files                           ?      294           
  Lines                           ?    10783           
  Branches                        ?     1612           
=======================================================
  Hits                            ?     6699           
  Misses                          ?     3487           
  Partials                        ?      597           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philasmar philasmar force-pushed the asmarp/fix-docker-images branch from bc51362 to 2b6cf6c Compare June 4, 2025 14:08
@philasmar philasmar merged commit 843a380 into feature/net8-upgrade Jun 5, 2025
10 of 13 checks passed
@philasmar philasmar deleted the asmarp/fix-docker-images branch June 5, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release Not Needed Add this label if a PR does not need to be released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants