Skip to content

fix: Spectre.CLI commands do not exit when pressing Ctrl + C#946

Merged
philasmar merged 1 commit intofeature/net8-upgradefrom
asmarp/fix-cancellation-issue
Jun 5, 2025
Merged

fix: Spectre.CLI commands do not exit when pressing Ctrl + C#946
philasmar merged 1 commit intofeature/net8-upgradefrom
asmarp/fix-cancellation-issue

Conversation

@philasmar
Copy link
Copy Markdown
Contributor

Description of changes:
Since we are already detecting the Ctrl + C press and canceling the cancellation token, I just needed to exit the environment.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@philasmar philasmar requested review from GarrettBeatty and normj June 4, 2025 18:35
@philasmar philasmar added the Release Not Needed Add this label if a PR does not need to be released. label Jun 4, 2025
Base automatically changed from asmarp/fix-docker-images to feature/net8-upgrade June 5, 2025 12:58
@philasmar philasmar force-pushed the asmarp/fix-cancellation-issue branch from 2538f06 to e071118 Compare June 5, 2025 12:59
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (feature/net8-upgrade@843a380). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...AWS.Deploy.CLI/Commands/CancellableAsyncCommand.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             feature/net8-upgrade     #946   +/-   ##
=======================================================
  Coverage                        ?   62.11%           
=======================================================
  Files                           ?      294           
  Lines                           ?    10784           
  Branches                        ?     1612           
=======================================================
  Hits                            ?     6699           
  Misses                          ?     3488           
  Partials                        ?      597           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philasmar philasmar merged commit 4bbabf6 into feature/net8-upgrade Jun 5, 2025
10 checks passed
@philasmar philasmar deleted the asmarp/fix-cancellation-issue branch June 5, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release Not Needed Add this label if a PR does not need to be released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants