Skip to content

fix: fix podman issue on windows#950

Merged
philasmar merged 1 commit intofeature/net8-upgradefrom
asmarp/fix-podman-on-windows
Jun 10, 2025
Merged

fix: fix podman issue on windows#950
philasmar merged 1 commit intofeature/net8-upgradefrom
asmarp/fix-podman-on-windows

Conversation

@philasmar
Copy link
Copy Markdown
Contributor

Description of changes:
Podman was not working on Windows. This PR fixes the command that checks if Podman is available.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@philasmar philasmar requested review from GarrettBeatty and normj June 10, 2025 16:04
@philasmar philasmar added the Release Not Needed Add this label if a PR does not need to be released. label Jun 10, 2025
Base automatically changed from asmarp/add-min-healthy-percent to feature/net8-upgrade June 10, 2025 16:35
@philasmar philasmar force-pushed the asmarp/fix-podman-on-windows branch from f3eae16 to c5d241d Compare June 10, 2025 16:36
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/net8-upgrade@f9675d1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/AWS.Deploy.Orchestration/Orchestrator.cs 50.00% 2 Missing and 3 partials ⚠️
....Deploy.Orchestration/SystemCapabilityEvaluator.cs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             feature/net8-upgrade     #950   +/-   ##
=======================================================
  Coverage                        ?   62.10%           
=======================================================
  Files                           ?      294           
  Lines                           ?    10796           
  Branches                        ?     1616           
=======================================================
  Hits                            ?     6705           
  Misses                          ?     3490           
  Partials                        ?      601           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philasmar philasmar merged commit fa867ce into feature/net8-upgrade Jun 10, 2025
10 checks passed
@philasmar philasmar deleted the asmarp/fix-podman-on-windows branch June 10, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release Not Needed Add this label if a PR does not need to be released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants