Merged
Conversation
c87bf3c to
37fa9d2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #964 +/- ##
=======================================
Coverage 62.11% 62.11%
=======================================
Files 294 294
Lines 10813 10813
Branches 1616 1616
=======================================
Hits 6717 6717
Misses 3494 3494
Partials 602 602 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
philasmar
approved these changes
Jul 14, 2025
AlexDaines
approved these changes
Jul 14, 2025
normj
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Update tests to use t3.micro free tier
it looks like there was a recent change where t3.micro is free tier now. so this updates the test to select "yes" for free tier so that t3.micro is used ( i couldnt find any news/docs on this change though so maybe im missing something)
below is query result i got when doing describe instances in us-west-2
Description of changes:
im not able to test in my personal isengard account because my account still shows t2.nano as free tier (idk why)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.