fix: handle unbound variable for stable parameter in verify_public_ecr and verify_dockerhub#1138
Merged
Merged
Conversation
…r and verify_dockerhub
mye956
approved these changes
May 14, 2026
danehlim
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish.shruns withset -euo pipefail. The-uflag causes bash to treat any reference to an unset variable as an error and immediately exit the script.verify_public_ecrandverify_dockerhubboth assigned their first positional parameter withstable=${1}. When either function is called without an argument,$1is unset and bash aborts the script withunbound variablebefore the verification logic runs.Changed
stable=${1}tostable=${1:-}in both functions. The:-default value syntax tells bash to use an empty string if$1is unset, satisfying-uwithout changing behavior when the argument is provided.Testing
A snippet to test the behavior
Output:
Description for the changelog
fix: handle unbound variable for
stableparameter inverify_public_ecrandverify_dockerhubLicensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.