fix: Fixed the verify_dockerhub and verify_public_ecr functions to use the correct reference tag when verifying BUILD_VERSION=3 releases.#1146
Merged
Conversation
… correct reference tag when verifying BUILD_VERSION=3 releases.
danehlim
approved these changes
May 26, 2026
ShelbyZ
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For BUILD_VERSION=3, the pipeline publishes a :3 major version tag instead of :latest. However, the verification functions were always comparing against :latest, then doing a separate optional check against :3. This meant:
This change will restructure both functions so the reference tag is selected based on BUILD_VERSION:
The check_tag_exists guard was also removed, meaning the :3 tag is now expected to exist when verifying a BUILD_VERSION=3 release.
Issue #, if available:
Testing
Manually tested via a separate bash script with the same logic
make debugsucceeded:Integ tests succeeded:
New tests cover the changes:
Description for the changelog
fix: Fixed the verify_dockerhub and verify_public_ecr functions to use the correct reference tag when verifying BUILD_VERSION=3 releases.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.