Skip to content

Use windows-2025 image in CI #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfod merged 3 commits into from
Jul 11, 2025
Merged

Use windows-2025 image in CI #821

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a91b04
Use latest windows in ci
sfodagain Jul 10, 2025
03e43e5
Fix unused var error
sfodagain Jul 10, 2025
34f4e70
Add comment
sfodagain Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,8 @@ jobs:
run: |
cd ${{ env.CI_FOLDER }}/aws-iot-device-sdk-cpp-v2
python ./deviceadvisor/script/DATestRun.py
windows-vs14:
runs-on: windows-2019 # windows-2019 is last env with Visual Studio 2015 (v14.0)
windows-vs17:
runs-on: windows-2025
strategy:
matrix:
arch: [Win32, x64]
Expand All @@ -216,7 +216,7 @@ jobs:
md ${{ env.CI_FOLDER }}
cd ${{ env.CI_FOLDER }}
python -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')"
python builder.pyz build -p ${{ env.PACKAGE_NAME }} --cmake-extra=-Tv140 --cmake-extra=-A${{ matrix.arch }}
python builder.pyz build -p ${{ env.PACKAGE_NAME }} --cmake-extra=-Tv143 --cmake-extra=-A${{ matrix.arch }}
Comment thread
sfod marked this conversation as resolved.
- name: Running samples in CI setup
run: |
python -m pip install boto3
Expand Down Expand Up @@ -302,7 +302,7 @@ jobs:
cd ${{ env.CI_FOLDER }}/aws-iot-device-sdk-cpp-v2
python ./deviceadvisor/script/DATestRun.py
windows-app-verifier:
runs-on: windows-2022 # latest
runs-on: windows-2025 # latest
permissions:
id-token: write # This is required for requesting the JWT
steps:
Expand Down
5 changes: 4 additions & 1 deletion eventstream_rpc/source/EventStreamClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1396,7 +1396,10 @@ namespace Aws
return true;
}

void StreamResponseHandler::OnStreamEvent(Crt::ScopedResource<AbstractShapeBase> response) {}
void StreamResponseHandler::OnStreamEvent(Crt::ScopedResource<AbstractShapeBase> response)
{
(void)response;
}

void StreamResponseHandler::OnStreamClosed() {}

Expand Down