Add CI to validate required files#665
Merged
Merged
Conversation
xiazhvera
changed the title
sbSteveK
reviewed
Oct 2, 2025
|
|
||
| ```sh | ||
| mvn compile exec:java -pl samples/Mqtt/Mqtt5X509 -Daws.crt.debugnative=true -Daws.crt.log.level=Debug -Daws.crt.log.destionation=Stdout -Dexec.mainClass=pubsub.PubSub -Dexec.args='--endpoint <endpoint> --cert <path to cert> --key <path to key>' | ||
| mvn compile exec:java -pl samples/Mqtt/Mqtt5X509 -Daws.crt.debugnative=true -Daws.crt.log.level=Debug -Daws.crt.log.destionation=Stdout -Dexec.mainClass=mqtt5x509.Mqtt5X509 -Dexec.args='--endpoint <endpoint> --cert <path to cert> --key <path to key>' |
Contributor
There was a problem hiding this comment.
The new samples have been adjusted to no longer need -Dexec.mainClass=mqtt5x509.Mqtt5X509. This example command should be simplified to:
mvn compile exec:java
-pl samples/Mqtt/Mqtt5X509
-Dexec.args="
--endpoint
--cert
--key "
sbSteveK
approved these changes
Oct 2, 2025
Contributor
sbSteveK
left a comment
sbSteveK
left a comment
There was a problem hiding this comment.
Please update the description of the PR from its default to what we're doing here. Fix addressed comments and ship
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.