Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the actual aws-crt dependency version to make docs #527

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

sfod
Copy link
Contributor

@sfod sfod commented Sep 4, 2024

Issue #, if available:

The current command for getting the CRT version is npm view aws-crt version. It returns the latest available version, not the actual dependency used.

Description of changes:

Parse aws-crt version from package.json.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sfod sfod merged commit 383e8b4 into main Sep 5, 2024
12 checks passed
@sfod sfod deleted the fix-crt-version-in-make-docs branch September 5, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants