Support Certs via Environement Variable#479
Open
Issacwww wants to merge 1 commit into
Open
Conversation
|
|
||
| func withCertsEnv() func(*config.LoadOptions) error { | ||
| return func(lo *config.LoadOptions) error { | ||
| certs := os.Getenv("CERTS_CONTENT") |
Contributor
There was a problem hiding this comment.
nit on naming:
Suggested change
| certs := os.Getenv("CERTS_CONTENT") | |
| certs := os.Getenv("ADDITIONAL_CA") |
| } | ||
| transport := &http.Transport{ | ||
| TLSClientConfig: &tls.Config{ | ||
| RootCAs: pool, |
Contributor
There was a problem hiding this comment.
Should we be merging the additional CA's into the default pool instead of the pool only containing the one passed in env?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The approach in #478 may be the best way to proceed. Open another PR to solve the same issue.
Testing:
Build image and pass the correct certs, the original CFN creation issue was resolved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.