Fix wherelen handling in BIO_ADDR_rawmake AF_UNIX path#3233
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3233 +/- ##
==========================================
+ Coverage 78.12% 78.29% +0.17%
==========================================
Files 689 689
Lines 123214 123217 +3
Branches 17137 17141 +4
==========================================
+ Hits 96257 96476 +219
+ Misses 26047 25829 -218
- Partials 910 912 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
approved these changes
May 8, 2026
crlorentzen
approved these changes
May 11, 2026
fed0b9f to
f13b21f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses
V2196133741Description of changes:
Two issues in the
AF_UNIXbranch ofBIO_ADDR_rawmake:wherelen + 1 > sizeof(...)wraps to 0 whenwherelen == SIZE_MAX, bypassing the bound check. Rewritten aswherelen >= sizeof(...).OPENSSL_strlcpy(dst, src, wherelen)treats its third argument as the destination buffer size, not the number of source bytes, so onlywherelen - 1bytes were copied andsrcwas required to be NUL-terminated even though the comment above states it isn't. Replaced withOPENSSL_memcpy; the precedingOPENSSL_cleanseofap->s_unalready leaves a trailing NUL.Call-outs:
None.
Testing:
Existing
bio_socket_testcases continue to pass.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.