[FIPS 4.0 CHERRY-PICK #3181 and #3194] Map rsaesOaep SPKI to RSA in parse_key_type#3246
Merged
justsmth merged 2 commits intoMay 13, 2026
Merged
Conversation
TPM 1.2 Endorsement Key certificates use rsaesOaep (OID 1.2.840.113549.1.1.7) as their SubjectPublicKeyInfo algorithm identifier. The underlying key is a standard RSA key. Without this mapping, X509_get_pubkey() fails with PUBLIC_KEY_DECODE_ERROR and X509_verify_cert() cannot validate these certificates. Add NID_rsaesOaep alongside the existing NID_rsa special case in parse_key_type() to return rsa_asn1_meth for both. Add a test for public key extraction using a real TPM 1.2 EK certificate with rsaesOaep SPKI.
crlorentzen
changed the title
crlorentzen
had a problem deploying
to
auto-approve
GitHub Actions
Failure
justsmth
approved these changes
May 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fips-2025-09-12-lts #3246 +/- ##
=======================================================
- Coverage 79.03% 78.75% -0.28%
=======================================================
Files 667 667
Lines 113339 113344 +5
Branches 16086 16082 -4
=======================================================
- Hits 89575 89265 -310
- Misses 22966 23283 +317
+ Partials 798 796 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samuel40791765
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
n/a
Description of changes:
Cherry-pick #3181 and #3194
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.