Quote LIBCRYPTO_PATH for dynamic load test#3259
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3259 +/- ##
==========================================
+ Coverage 78.15% 78.18% +0.02%
==========================================
Files 689 689
Lines 123678 123678
Branches 17192 17193 +1
==========================================
+ Hits 96663 96696 +33
+ Misses 26097 26064 -33
Partials 918 918 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
approved these changes
May 20, 2026
samuel40791765
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LIBCRYPTO_PATHas a quoted string literal at the CMake level (-DLIBCRYPTO_PATH=\"...\") so it can be consumed directly by the test as aconst char *.xstr/strstringification macros andDYNAMIC_LIBRARY_PATHindirection indynamic_loading_test.c, usingLIBCRYPTO_PATHdirectly.Why
Stringification via
#/xstrdoes not handle paths containing characters that aren't valid in C identifiers/tokens (e.g., spaces, hyphens in some contexts). Quoting at the compile-define level is more robust and lets the test consume the macro as-is.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.