Skip to content

Quote LIBCRYPTO_PATH for dynamic load test#3259

Merged
justsmth merged 3 commits into
aws:mainfrom
WillChilds-Klein:quote-libcrypto-path
May 29, 2026
Merged

Quote LIBCRYPTO_PATH for dynamic load test#3259
justsmth merged 3 commits into
aws:mainfrom
WillChilds-Klein:quote-libcrypto-path

Conversation

@WillChilds-Klein

@WillChilds-Klein WillChilds-Klein commented May 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Pass LIBCRYPTO_PATH as a quoted string literal at the CMake level (-DLIBCRYPTO_PATH=\"...\") so it can be consumed directly by the test as a const char *.
  • Remove the now-redundant xstr/str stringification macros and DYNAMIC_LIBRARY_PATH indirection in dynamic_loading_test.c, using LIBCRYPTO_PATH directly.

Why

Stringification via #/xstr does not handle paths containing characters that aren't valid in C identifiers/tokens (e.g., spaces, hyphens in some contexts). Quoting at the compile-define level is more robust and lets the test consume the macro as-is.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter

codecov-commenter commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.18%. Comparing base (6f246af) to head (3455dcb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3259      +/-   ##
==========================================
+ Coverage   78.15%   78.18%   +0.02%     
==========================================
  Files         689      689              
  Lines      123678   123678              
  Branches    17192    17193       +1     
==========================================
+ Hits        96663    96696      +33     
+ Misses      26097    26064      -33     
  Partials      918      918              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WillChilds-Klein WillChilds-Klein marked this pull request as ready for review May 20, 2026 17:46
@WillChilds-Klein WillChilds-Klein requested a review from a team as a code owner May 20, 2026 17:46
@WillChilds-Klein WillChilds-Klein requested a review from justsmth May 20, 2026 20:02
@WillChilds-Klein WillChilds-Klein enabled auto-merge (squash) May 20, 2026 20:04
@justsmth justsmth requested a review from samuel40791765 May 27, 2026 13:03
@justsmth justsmth merged commit 9426cbf into aws:main May 29, 2026
510 of 855 checks passed
@WillChilds-Klein WillChilds-Klein deleted the quote-libcrypto-path branch May 30, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants