Prefer CRLs with specific IDP match#3264
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3264 +/- ##
=======================================
Coverage 78.11% 78.12%
=======================================
Files 689 689
Lines 123460 123526 +66
Branches 17196 17198 +2
=======================================
+ Hits 96442 96504 +62
- Misses 26097 26103 +6
+ Partials 921 919 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samuel40791765
previously approved these changes
May 22, 2026
justsmth
previously approved these changes
May 22, 2026
f9d720b to
1a5583f
Compare
nebeid
approved these changes
May 22, 2026
samuel40791765
approved these changes
May 22, 2026
justsmth
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses D435946985
Description of changes:
When multiple CRLs are candidates during revocation checking, AWS-LC did not distinguish between a CRL whose IDP specifically matches the certificate's distribution point and a CRL with no IDP or an empty IDP. A broad CRL that is newer or loaded first could outrank a specific CRL, causing a revoked certificate to verify as valid.
This change introduces a new score bit
CRL_SCORE_IDP_MATCHso that a CRL with a specific IDP match is always preferred over a broad no-IDP/empty-IDP CRL.crl_crldp_checknow reports whether the match was specific via anidp_matchout-parameter, andget_crl_scoreuses this to set the new bit. The bit is placed belowCRL_SCORE_TIMEso that an expired or unprocessable specific-IDP CRL cannot outrank a valid broad CRL.Testing:
Unit tests added covering: specific vs. broad CRL preference regardless of freshness or load order, expired specific CRL losing to valid broad CRL, and specific CRL with unknown critical extension losing to processable broad CRL.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.