Gate Linux specific code to fix compilation on AIX#3265
Merged
Conversation
justsmth
reviewed
May 22, 2026
justsmth
previously approved these changes
May 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3265 +/- ##
==========================================
- Coverage 78.28% 78.10% -0.19%
==========================================
Files 689 689
Lines 123463 123460 -3
Branches 17200 17196 -4
==========================================
- Hits 96659 96429 -230
- Misses 25881 26110 +229
+ Partials 923 921 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
If IBM AIX could just get |
Contributor
Author
|
@torben-hansen agreed 😄 Thanks for the reviews ! |
torben-hansen
approved these changes
May 22, 2026
justsmth
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
None, but I can open one if needed.
I'm trying to build a Rust binary which depends on the
aws-lc-syscrate on IBM AIX (a Unix OS), this PR gates linux-specific symbols to fix compiler errors.Description of changes:
getrandomlogic withOPENSSL_LINUX(on top ofOPENSSL_RAND_URANDOM), I believe this logic is only reachable on LinuxRNDGETENTCNTwithOPENSSL_LINUXas the symbol is defined inlinux/random.hCall-outs:
I'm aware AIX is not a supported platform, but the changes required to make it compile are minimal, and I think it makes the code technically more correct. Let me know what you think.
Testing:
Ran tests locally, built the library on an AIX host.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.