command_executer - recv infinite loop #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanzu
force-pushed
the
patch-1
branch
2 times, most recently
from
4374cd8 to
da580f5
Compare
atanzu
approved these changes
Feb 18, 2025
The command_executer/src/protocol_helpers.rs has a denial of service bug. The `recv` method may return 0 bytes (the `size`) variable, and this case is not accounted for: the 0 may be added to the `recv_bytes` infinitely. Similar issue exists in vsock_sample: https://github.com/aws/aws-nitro-enclaves-samples/blob/dc4bba3d99bc4988a87ce7775cf1bc554537da16/vsock_sample/rs/src/protocol_helpers.rs#L45-L52 Correct handling is implemented in python versions and in the kmstool: https://github.com/aws/aws-nitro-enclaves-sdk-c/blob/550f7313bf792bf03200c7c6e1ac3fd7d2dc382f/bin/kmstool-enclave/main.c#L245-L247
clupuishere
approved these changes
Feb 20, 2025
mariusknaust
approved these changes
Feb 20, 2025
dwhjames
added a commit
to dwhjames/aws-nitro-enclaves-samples
that referenced
this pull request
Mar 31, 2025
Issue raised in - aws/aws-nitro-enclaves-cli#609 Replicating similar fix here. Indicate count of bytes received and expected bytes in error string. --- Documentation links: - https://docs.rs/nix/latest/nix/sys/socket/fn.recv.html - https://pubs.opengroup.org/onlinepubs/9699919799/functions/recv.html - https://man7.org/linux/man-pages/man2/recv.2.html
Fix contributed here |
atanzu
pushed a commit
to aws/aws-nitro-enclaves-samples
that referenced
this pull request
Mar 31, 2025
Issue raised in - aws/aws-nitro-enclaves-cli#609 Replicating similar fix here. Indicate count of bytes received and expected bytes in error string. --- Documentation links: - https://docs.rs/nix/latest/nix/sys/socket/fn.recv.html - https://pubs.opengroup.org/onlinepubs/9699919799/functions/recv.html - https://man7.org/linux/man-pages/man2/recv.2.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command_executer/src/protocol_helpers.rs has a denial of service bug. The
recvmethod may return 0 bytes (thesize) variable, and this case is not accounted for: the 0 may be added to therecv_bytesinfinitely.Similar issue exists in vsock_sample: https://github.com/aws/aws-nitro-enclaves-samples/blob/dc4bba3d99bc4988a87ce7775cf1bc554537da16/vsock_sample/rs/src/protocol_helpers.rs#L45-L52
Correct handling is implemented in python versions and in the kmstool: https://github.com/aws/aws-nitro-enclaves-sdk-c/blob/550f7313bf792bf03200c7c6e1ac3fd7d2dc382f/bin/kmstool-enclave/main.c#L245-L247
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.