Use private-key parameter for KMS keys #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows to pass KMS key ARN via the `--private-key` parameter. The underlying crate `aws-nitro-enclaves-image-format` will parse the given value and decide if a KMS key or a local key is given. Parameters `--kms-key-id` and `--kms-key-region` have been removed. Signed-off-by: Mark Kirichenko <[email protected]>
This commit fixes the quotation symbols in event configuration in order to unblodk the workflow. Signed-off-by: Mark Kirichenko <[email protected]>
mariusknaust
approved these changes
Jan 28, 2025
eugkoira
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#204
Description of changes:
This PR allows to pass KMS key ARN via the
--private-keyparameter. The underlying crateaws-nitro-enclaves-image-formatwill parse the given value and decide if a KMS key or a local key is given.Parameters
--kms-key-idand--kms-key-regionhave been removed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.