Extend CI with KMS-based key tests #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanzu
force-pushed
the
feature/tests-with-kms-keys
branch
from
46f656e to
c33782a
Compare
atanzu
force-pushed
the
feature/tests-with-kms-keys
branch
from
c33782a to
8a696e4
Compare
clupuishere
approved these changes
Feb 20, 2025
mariusknaust
approved these changes
Feb 20, 2025
atanzu
force-pushed
the
feature/tests-with-kms-keys
branch
from
8a696e4 to
1ef3c41
Compare
This commit modifies the CI script to obtain parameters from SSM which are needed to run tests with KMS keys. Signed-off-by: Mark Kirichenko <[email protected]>
This commit adds tests which use KMS keys to sign EIFs. Signed-off-by: Mark Kirichenko <[email protected]>
atanzu
force-pushed
the
feature/tests-with-kms-keys
branch
from
1ef3c41 to
ae45094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds tests that use a KMS key for signing EIFs. This new test suite requires to set environment variables
TEST_KMS_KEY_ARNandTEST_CERTIFICATE_PATH.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.