refactor: remove duplicate code and fix indentation #8011
Merged
+24
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/package
vicheey
reviewed
May 8, 2025
samcli/lib/bootstrap/bootstrap.py
Outdated
| """ | ||
| message = f"\n\tManaged S3 bucket: {s3_bucket}" | ||
| click.secho(message, bold=bold) | ||
| click.echo("\tA different default S3 bucket can be set in samconfig.toml") |
There was a problem hiding this comment.
I think this is an opportunity to improve on the message as well.
Suggested change
| click.echo("\tA different default S3 bucket can be set in samconfig.toml") | |
| click.echo("\tTo use a specify bucket, specify `resolve_s3 = false` and `s3_bucket= <bucket arn>`") |
Then we can remove the condition in line 57 and 58. We can consolidate these to one message.
There was a problem hiding this comment.
We can definitely improve on the messaging and removing branching overall.
* Set the right indentation across `package`, `deploy`, `package/deploy --resolve-s3` & `deploy --guided` * Set the right indentation on `Skipping upload` to S3.
vicheey
approved these changes
May 9, 2025
roger-zhangg
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package,deploy,package/deploy --resolve-s3&deploy --guidedSkipping uploadto S3.Which issue(s) does this change fix?
No explicit issue against this.
Why is this change necessary?
The indentation was not aligned.
BEFORE:
AFTER:
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.