Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds IgnoreConfiguredEndpoints and BaseEndpoint to config.LoadOptions #2425

Closed
wants to merge 1 commit into from
Closed

Adds IgnoreConfiguredEndpoints and BaseEndpoint to config.LoadOptions #2425

wants to merge 1 commit into from

Conversation

gdavison
Copy link
Contributor

Adds the parameters IgnoreConfiguredEndpoints and BaseEndpoint to config.LoadOptions, corresponding to the parameters on config.EnvConfig and config.SharedConfig.

Also adds functional options config.WithIgnoreConfiguredEndpoints and config.WithBaseEndpoint

Closes #2422
Closes #2423

@gdavison gdavison requested a review from a team as a code owner December 11, 2023 23:27
@lucix-aws
Copy link
Contributor

Thanks for taking the time to do this, LGTM.

@gdavison gdavison marked this pull request as draft December 12, 2023 18:37
@gdavison
Copy link
Contributor Author

I've found an error in the code, so I'm switching the PR to a draft

@lucix-aws lucix-aws closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucix-aws lucix-aws lucix-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gdavison @lucix-aws