Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #2383 #3004

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Fix for #2383 #3004

merged 2 commits into from
Feb 6, 2025

Conversation

badu
Copy link
Contributor

@badu badu commented Feb 6, 2025

DynamoDB AttributeValue's MarshallMap() Does Not Support time.Time Correctly

Closes #2383

Added a EncoderOption called OmitEmptyTime, so we don't introduce breaking changes.

@badu badu requested a review from a team as a code owner February 6, 2025 08:28
Copy link
Contributor

@lucix-aws lucix-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, JFYI - integration tests will fail in forks, don't worry about those.

@lucix-aws lucix-aws merged commit d4c5594 into aws:main Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB AttributeValue's MarshallMap() Does Not Support time.Time Correctly
2 participants