Add support for producing EnhancedType with tableSchema from Sets #3014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
There's support for Sets in
DefaultAttributeConverterProvider
, but it was missing fromBeanTableSchema
. As a result, Sets always require a customer converter, but Lists do not. This adds support forSet
inBeanTableSchema
.Modifications
I added a stanza in
BeanTableSchema::convertTypeToEnhancedType
that checks if the type is aSet
, and handles it analogously to how lists and maps are being handled. I also added a test modelled on the existing tests for list and map.Testing
I couldn't get the project building locally, so I haven't tested it.
Screenshots (if appropriate)
Types of changes
I don't know which of these it is. It seems like a bug, since there is support for
Set
half implemented, but it's not documented anywhere.Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License