Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for producing EnhancedType with tableSchema from Sets #3014

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaredwindover
Copy link

Motivation and Context

There's support for Sets in DefaultAttributeConverterProvider, but it was missing from BeanTableSchema. As a result, Sets always require a customer converter, but Lists do not. This adds support for Set in BeanTableSchema.

Modifications

I added a stanza in BeanTableSchema::convertTypeToEnhancedType that checks if the type is a Set, and handles it analogously to how lists and maps are being handled. I also added a test modelled on the existing tests for list and map.

Testing

I couldn't get the project building locally, so I haven't tested it.

Screenshots (if appropriate)

Types of changes

I don't know which of these it is. It seems like a bug, since there is support for Set half implemented, but it's not documented anywhere.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@jaredwindover jaredwindover requested a review from a team as a code owner February 3, 2022 18:20
aws-sdk-java-automation added a commit that referenced this pull request May 2, 2024
…bf78b255e

Pull request: release <- staging/4c7cd577-9606-45a5-b82e-0cbbf78b255e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant