Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could software.amazon.awssdk:build-tools:1.0 drop off redundant dependencies? #3192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Celebrate-future
Copy link

@Celebrate-future Celebrate-future commented May 16, 2022

image
Hi! I found the pom file of project software.amazon.awssdk:build-tools:1.0 introduced 33 dependencies. However, among them, 5 libraries (15%) are not used by your project. I list the redundant dependencies below (labelled as red ones in the figure):

Redundant dependencies

com.google.code.findbugs:jsr305:jar:3.0.2:compile
net.jcip:jcip-annotations:jar:1.0:compile
com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
com.google.j2objc:j2objc-annotations:jar:1.3:compile
com.google.errorprone:error_prone_annotations:jar:2.5.1:compile

Outdated dependencies

com.google.j2objc:j2objc-annotations:1.3 (2383 days without maintenance)
net.jcip:jcip-annotations:1.0 (5463 days without maintenance)


Removing the redundant dependencies can reduce the size of project and prevent potential dependency conflict issues (i.e., multiple versions of the same library). More importantly, one of the redundant dependencies com.google.code.findbugs:jsr305:jar:3.0.2:compile induced dependency conflict in the dependency graph. As such, I suggest a refactoring operation for software.amazon.awssdk:build-tools:1.0’s pom file.

The attached PR helps resolve the reported problem. It is safe to remove the unused libraries (we considered Java reflection relations when analyzing the dependencies). These changes have passed software.amazon.awssdk:build-tools:1.0’s maven tests.

Best regards

@Celebrate-future Celebrate-future requested a review from a team as a code owner May 16, 2022 03:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

aws-sdk-java-automation added a commit that referenced this pull request Aug 22, 2024
…0cbb0c81e

Pull request: release <- staging/f9c5bfc5-da3d-43ce-b776-19b0cbb0c81e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant