Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-use HttpResponseHandler headers #3204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Re-use HttpResponseHandler headers #3204

wants to merge 1 commit into from

Conversation

marcogrcr
Copy link

@marcogrcr marcogrcr commented May 20, 2022 •
edited
Loading

Re-use HttpResponseHandler constant header names instead of duplicating these values.

Motivation and Context

Don't repeat yourself.

Modifications

  • Re-use HttpResponseHandler.X_AMZN_REQUEST_ID_HEADER in AwsXmlResponseTransformer instead of duplicating this header name.
  • Re-use HttpResponseHandler.X_AMZN_REQUEST_ID_HEADER_ALTERNATE in ExceptionTranslationInterceptor instead of duplicating this header name.
  • Re-use HttpResponseHandler.X_AMZ_ID_2_HEADER in AwsXmlErrorUnmarshaller instead of duplicating this header name.

Testing

Successful build of ./mvnw clean install -pl :aws-query-protocol -am

Screenshots (if appropriate)

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code maintainability (non-breaking change which makes code easier to maintain)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
    • I have not added a changelog entry, because this change is completely internal and has negligible customer impact.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@marcogrcr marcogrcr requested a review from a team as a code owner May 20, 2022 06:57
@marcogrcr
Re-use HttpResponseHandler headers
8a4cee1 
WHAT?

- Re-use `HttpResponseHandler.X_AMZN_REQUEST_ID_HEADER` in
  `AwsXmlResponseTransformer` instead of duplicating this header name.
- Re-use `HttpResponseHandler.X_AMZN_REQUEST_ID_HEADER_ALTERNATE` in
  `ExceptionTranslationInterceptor` instead of duplicating this header
  name.
- Re-use `HttpResponseHandler.X_AMZ_ID_2_HEADER` in
  `AwsXmlErrorUnmarshaller` instead of duplicating this header name.

WHY?

Don't repeat yourself.

HOW?

Successful build of:

- `./mvnw clean install -pl :aws-query-protocol -am`
- `./mvnw clean install -pl :aws-xml-protocol -am`
- `./mvnw clean install -pl :s3 -am`
@marcogrcr marcogrcr changed the title Re-use HttpResponseHandler.X_AMZ_ID_2_HEADER Re-use HttpResponseHandler headers May 20, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marcogrcr