Refactor tryDetectRegion Method . Remove aws-json-protocol dependency #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joviegas
reviewed
Jul 27, 2022
core/imds/src/main/java/software/amazon/awssdk/imds/internal/DefaultEc2Metadata.java
Show resolved
Hide resolved
joviegas
approved these changes
Jul 27, 2022
|
SonarCloud Quality Gate failed. |
zoewangg
reviewed
Jul 29, 2022
| @@ -72,7 +72,7 @@ private DefaultEc2Metadata(DefaultEc2Metadata.Ec2MetadataBuilder builder) { | |||
| this.tokenTtl = builder.tokenTtl != null ? builder.tokenTtl : Duration.ofSeconds(21600); | |||
| this.endpointMode = ENDPOINT_PROVIDER.resolveEndpointMode(builder.endpointMode); | |||
| this.httpDebugOutput = builder.httpDebugOutput; | |||
| this.httpClient = builder.httpClient != null ? builder.httpClient : UrlConnectionHttpClient.create(); | |||
| this.httpClient = builder.httpClient != null ? builder.httpClient : ApacheHttpClient.create(); | |||
There was a problem hiding this comment.
This would cause build to fail for applications that only have/use UrlConnectionHttpClient as HTTP dependency.
We should load the http client using the default chain instead of defaulting to an implementation explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor tryDetectRegion Method . Remove aws-json-protocol dependency
Motivation and Context
Refactor tryDetectRegion Method . Remove aws-json-protocol dependency
Modifications
Refactor tryDetectRegion Method . Remove aws-json-protocol dependency
Testing
Ran Existing InstanceProfileRegionProvider Test and is compliant.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License