Issue #3365 - adding response metadata into enhanced response objects #3413
Conversation
petercipov
changed the title
There was a problem hiding this comment.
Thanks for very thorough unit testing!
Please add functional tests too and update BasicCrudTest and AsyncBasicCrudTest. It should be sufficient with updating or adding one test case per test file. I'd recommend updating if there's a decent test case to piggy back, because the test classes are already very long.
| return result; | ||
| } | ||
|
|
||
| @NotThreadSafe | ||
| public static final class Builder<T> { | ||
| public DynamoDbResponseMetadata responseMetadata; |
There was a problem hiding this comment.
Should be private as in DeleteItemEnhancedResponse
Nit: put it as the last instance variable for consistency
| return result; | ||
| } | ||
|
|
||
| @NotThreadSafe | ||
| public static final class Builder<T> { | ||
| public DynamoDbResponseMetadata responseMetadata; |
There was a problem hiding this comment.
Should be private as in DeleteItemEnhancedResponse
Nit: put it as the last instance variable for consistency
| DynamoDbResponseMetadata dynamoDbResponseMetadata = | ||
| DynamoDbResponseMetadata.create(DefaultAwsResponseMetadata.create(metadataMap)); | ||
|
|
||
| DeleteItemEnhancedResponse<FakeItem> containsItemCollectionMetrics = DeleteItemEnhancedResponse.builder(FakeItem.class) |
There was a problem hiding this comment.
Nit: update name of variable to reference ResponseMetadata
| DynamoDbResponseMetadata dynamoDbResponseMetadata = | ||
| DynamoDbResponseMetadata.create(DefaultAwsResponseMetadata.create(metadataMap)); | ||
|
|
||
| PutItemEnhancedResponse<FakeItem> containsItemCollectionMetrics = PutItemEnhancedResponse.builder(FakeItem.class) |
There was a problem hiding this comment.
Nit: update name of variable to reference ResponseMetadata
| DynamoDbResponseMetadata dynamoDbResponseMetadata = | ||
| DynamoDbResponseMetadata.create(DefaultAwsResponseMetadata.create(metadataMap)); | ||
|
|
||
| UpdateItemEnhancedResponse<FakeItem> containsItemCollectionMetrics = UpdateItemEnhancedResponse.builder(FakeItem.class) |
There was a problem hiding this comment.
Nit: update name of variable to reference ResponseMetadata
|
@cenedhryn Thank you for your time on review, I have pushed my changes with requested changes. |
Motivation and Context
Issue #3365
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License