Changed GeneratedServiceMetadataProvider to lazily load elements. Updated unit tests based to reflect changes. #3686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
GeneratedServiceMetadataProvider
takes a while to initialize. This was benchmarked and shown in this ticket. Lazily loading metadata significantly reduces the overhead required to initialize this class and reduces the time it takes to load substantially. This is important in the era of serverless infrastructure where cold start times need to be minimized.Resolves #3664
Modifications
ServiceMetadataProviderGenerator
ServiceMetadata
entries in the constructorServiceMetadata
factory method which accepts aString
value (same as before) and generates the associatedServiceMetadata
when required.ServiceMetadata
objects are cached using the same map as before and this is checked prior to calling the factoryservice-metadata-provider.java
to reflect newGeneratedServiceMetadataProvider
structureTesting
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License