Include provided ARN string in Exception message. Enforce NPE.

[belugabehr]

Motivation and Context

I recently had a complicated unit test that was failing to produce a valid ARN. However, the Exception message from parsing the ARN did not provide the value it was attempting to parse, so it was made more difficult to troubleshoot.

Modifications

• Add 'arn' being parsed into the Exception message
• Add explicit enforcement of null/empty/blank 'arn' string
• Wrap a root IllegalArgumentException with the details of the failed parsing inside another IllegalArgumentException which contains the value of the ARN being parsed.

Testing

Added additional unit tests to cover these cases

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[L-Applin]

Change looks good. Thanks for improving logging while preserving the same behaviour.

There are test failures

[L-Applin]

I noticed that tests in software.amazon.awssdk.services.s3.internal.resource.S3ArnConverterTest are failing due to exception message change:

• parseArn_objectLambda_noName_colon

Expected: (an instance of java.lang.IllegalArgumentException and exception with message a string containing "resource must not be blank or empty")
--
but: exception with message a string containing "resource must not be blank or empty" message was "Malformed ARN: arn:aws:s3-object-lambda:us-west-2:123456789012:accesspoint:"

• parseArn_objectLambda_noName_slash

Expected: (an instance of java.lang.IllegalArgumentException and exception with message a string containing "resource must not be blank or empty")
--
but: exception with message a string containing "resource must not be blank or empty" message was "Malformed ARN: arn:aws:s3-object-lambda:us-west-2:123456789012:accesspoint/"

@belugabehr please also update those tests to take your changes in account. Thanks!

[debora-ito]

@belugabehr let us know if you want to keep working in this PR.

[belugabehr]

@debora-ito Other priorities keeping me from finishing - but my intent is to see it through. Thanks for the patience.

[belugabehr]

@L-Applin Updated. Thanks.

[belugabehr]

@L-Applin @debora-ito Any updates?

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[belugabehr]

Hey, sorry for all the SPAM on this PR. It's been so long since I've looked at this that I am falling into the same traps I fell into months ago.

I think the proposed solution is optimal. Users are told that their ARNs are not valid, and then they can dive into the cause to get the details of why.

The issue here is that there is another Exception that gets thrown from the Resource parsing code. The resource parsing code is only handled the resource string, not the entire ARN, so it cannot emit a proper exception with the ARN present.

need to address exception wrapping

[belugabehr]

Removed this on purpose as it is duplicative. The resource is further parsed (and validated) in the Resource parsing code.