Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug bash] Allow ResponseBody.toFile option to override file #3772

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[Bug bash] Allow ResponseBody.toFile option to override file #3772

wants to merge 6 commits into from

Conversation

L-Applin
Copy link
Contributor

fixes issue 2300

Allow ResponseBody.toFile option to override file by passing StandardCopyOptions.

@L-Applin L-Applin requested a review from a team as a code owner February 17, 2023 21:30
@L-Applin L-Applin changed the title Allow ResponseBody.toFile option to override file [Bug bash] Allow ResponseBody.toFile option to override file Feb 17, 2023
@L-Applin L-Applin requested a review from zoewangg February 20, 2023 15:50
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zoewangg
Copy link
Contributor

We should probably make it consistent with our async counterpart.

https://github.com/aws/aws-sdk-java-v2/blob/master/core/sdk-core/src/main/java/software/amazon/awssdk/core/async/AsyncResponseTransformer.java#L180

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@i-avalos
Copy link

any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoewangg zoewangg Awaiting requested review from zoewangg

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3: GetObjectRequest toFile option to override file
3 participants
@L-Applin @zoewangg @i-avalos