Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore abstract toBuilder methods #4047

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sugmanue
Copy link
Contributor

Motivation and Context

Currently abstract classes with abstract toBuilder methods will fail the validation with

toBuilder() does not invoke a constructor or method on a builder. A toBuilder() method must either invoke a builder constructor or call builder() and configure the fields on the builder.

Modifications

Added the method to the ignoredBuildables if the method is abstract.

Testing

Locally using a branch with an abstract toBuilder method.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@sugmanue sugmanue requested a review from a team as a code owner May 26, 2023 22:32
@sugmanue sugmanue requested a review from L-Applin May 26, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants