MappingSubscriber should halt upon any Exception #4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catching only RuntimeException means anything awaiting a result from a Publisher will hang indefinitely, even after a coroutine has ended exceptionally.
|
Yes, Kotlin does have built-in exceptions that do not inherit from |
zoewangg
reviewed
Aug 29, 2023
| @@ -69,7 +69,7 @@ public void onNext(T t) { | |||
| if (!isCancelled) { | |||
| try { | |||
| delegateSubscriber.onNext(mapFunction.apply(t)); | |||
| } catch (RuntimeException e) { | |||
| } catch (Exception e) { | |||
There was a problem hiding this comment.
Should we catch Throwable?
There was a problem hiding this comment.
Why not? I don't think we can catch too many exceptions here.
There was a problem hiding this comment.
@polyatail can you update the PR and add Throwable?
|
is there any update about this issue? |
|
Please merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When using
SdkPublisher.map, if the mapping function throws an exception that does not inherit fromRuntimeException(which often is the case in Kotlin), anything awaiting a result from the Publisher will hang indefinitely, even though the coroutine has ended exceptionally.Modifications
This change catches and terminates on all exceptions.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License