-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set expirationTime when building AwsSessionCredentials in HttpCredent… #5189
base: master
Are you sure you want to change the base?
Conversation
…ialsLoader.getAwsCredentials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could HttpCredentialsLoaderTest be updated to validate that expirationTime
is set correctly?
@clint42 let us know if you still want to keep this PR moving forward. |
@debora-ito Yes please, I have trouble running the test locally, so I haven't submitted the requested changes yet but it is coming as soon as I get a bit of time to dedicate to it. |
Set expirationTime when building AwsSessionCredentials in HttpCredentialsLoader.getAwsCredentials
Motivation and Context
When resolving credentials using ContainerCredentialsProvider, expirationTime has always no value.
This change ensure that the value is properly set.
Modifications
Setting expirationTime
Testing
Ran the already existing test suites.
Build :auth module and used it in my application. Logged and verified that expirationTime is not null
This change does not affects other areas of the code. It simply set a property that should have been set and makes the behaviour consistent with documentation
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License