Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set expirationTime when building AwsSessionCredentials in HttpCredent… #5189

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

clint42
Copy link

@clint42 clint42 commented May 6, 2024

Set expirationTime when building AwsSessionCredentials in HttpCredentialsLoader.getAwsCredentials

Motivation and Context

When resolving credentials using ContainerCredentialsProvider, expirationTime has always no value.
This change ensure that the value is properly set.

Modifications

Setting expirationTime

Testing

Ran the already existing test suites.

Build :auth module and used it in my application. Logged and verified that expirationTime is not null

This change does not affects other areas of the code. It simply set a property that should have been set and makes the behaviour consistent with documentation

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@clint42 clint42 requested a review from a team as a code owner May 6, 2024 23:09
@debora-ito debora-ito added the needs-review This issue or PR needs review from the team. label May 15, 2024
@L-Applin L-Applin self-assigned this May 21, 2024
@debora-ito debora-ito removed the needs-review This issue or PR needs review from the team. label May 22, 2024
Copy link
Contributor

@L-Applin L-Applin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could HttpCredentialsLoaderTest be updated to validate that expirationTime is set correctly?

@debora-ito
Copy link
Member

@clint42 let us know if you still want to keep this PR moving forward.

@debora-ito debora-ito added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. label Jun 11, 2024
@clint42
Copy link
Author

clint42 commented Jun 15, 2024

@debora-ito Yes please, I have trouble running the test locally, so I haven't submitted the requested changes yet but it is coming as soon as I get a bit of time to dedicate to it.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants