Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reflection for removed class, remove deprecated graal-vm option #5408

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Bhashit
Copy link

@Bhashit Bhashit commented Jul 18, 2024

Motivation and Context

Removal of reflection-config for an unused class

The class in question has been removed from the source-code of this repo, but the reflection-config still refers to it. This causes GraalVM to generate an error. The resulting builds behave incorrectly.

Removal of a deprecated GraalVM option

The --allow-incomplete-classpath option is deprecated in GraalVM and generates warnings during builds.

Checklist

  • [x ] I have read the CONTRIBUTING document
  • [ x] Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [x ] I confirm that this pull request can be released under the Apache 2 license

@Bhashit Bhashit requested a review from a team as a code owner July 18, 2024 05:13
@L-Applin L-Applin self-assigned this Jul 22, 2024
@@ -1,11 +0,0 @@
[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The native-build fails to parse this file, it needs to at least have some content in it. Could you please leave an empty array here? You can can test locally what the native build test by looking at the buildspec/native-image-integ-test.yml file and reproducing locally, ie:

mvn clean install -pl :sdk-native-image-test -P quick --am -T1C
mvn clean install -pl :bom-internal,:bom
cd test/sdk-native-image-test
mvn clean package -P native-image
target/sdk-native-image-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants