Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose crt connection timeout #5835

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Fred1155
Copy link
Contributor

Motivation and Context

CRT HTTP client Java binding added support for connection acquire timeout, we also need to expose the connectionAcquisitionTimeout field in crt http client and pass it through

Modifications

  1. Change the awscrt.version from 0.33.6 to 0.33.9
  2. Added connectionAcquisitionTimeout method in AwsCrtHttpClient.Builder and AwsCrtAsyncHttpClient.Builder
  3. Implemented connectionAcquisitionTimeout method in AwsCrtClientBuilderBase
  4. Pass through the connectionAcquisitionTimeout in AwsCrtHttpClientBase

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@Fred1155 Fred1155 requested a review from a team as a code owner January 28, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant