Fixing nullability issue of message and adding test coverage #5907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
approved these changes
Feb 27, 2025
RanVaknin
force-pushed
the
revert-aws-service-exception-to-being-nullable
branch
from
b6b99fc to
b52f5a6
Compare
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@all-contributors please add @RanVaknin for code |
|
I've put up a pull request to add @RanVaknin! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#5834 refactors
AwsServiceExceptionto add the SDK diagnostics conditionally and refactors thegetMessageimpl to use String joiner. This change makes AwsServiceException's getMessage to always be not null which can break customers who are relying on nullability.This change preserves the behavior pre #5834.
Added test coverage.