Skip to content

Add http client test suite for long-running request patterns#6924

Merged
Fred1155 merged 7 commits into
masterfrom
bole/long_polling_http_test_suite
May 6, 2026
Merged

Add http client test suite for long-running request patterns#6924
Fred1155 merged 7 commits into
masterfrom
bole/long_polling_http_test_suite

Conversation

@Fred1155

Copy link
Copy Markdown
Contributor

Motivation and Context

This change adds a shared, cross-client test suite that validates timeout behavior for long running request patterns across all HTTP client implementations.

Modifications

Added a shared test suite under test/http-client-tests that each HTTP client module extends:

  • SdkHttpClientLongRunningRequestTestSuite — sync clients (Apache, Apache5, URL Connection, CRT sync)
  • SdkAsyncHttpClientLongRunningRequestTestSuite — async clients (Netty, CRT async)
  • LongRunningRequestTestSupport — shared WireMock stubs and the time-bound assertion helper
    Each suite contains three tests that validate the client fails fast rather than hanging when a timeout is configured and the server misbehaves:

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@Fred1155 Fred1155 requested a review from a team as a code owner April 30, 2026 18:19
@Fred1155 Fred1155 added this pull request to the merge queue May 6, 2026
Merged via the queue into master with commit 940735d May 6, 2026
11 of 12 checks passed
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 6, 2026
@Fred1155 Fred1155 deleted the bole/long_polling_http_test_suite branch May 11, 2026 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants