Skip to content

Fix flakey integ test by adding params #7146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RanVaknin wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −3
Open

Fix flakey integ test by adding params #7146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...tch/src/it/java/software/amazon/awssdk/services/cloudwatch/CloudWatchIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import static software.amazon.awssdk.testutils.service.AwsTestBase.isValidSdkServiceException;

import java.io.IOException;
import java.time.Duration;
Expand All @@ -42,7 +41,6 @@
import software.amazon.awssdk.auth.credentials.StaticCredentialsProvider;
import software.amazon.awssdk.core.CompressionConfiguration;
import software.amazon.awssdk.core.SdkGlobalTime;
import software.amazon.awssdk.core.exception.SdkServiceException;
import software.amazon.awssdk.core.interceptor.SdkInternalExecutionAttribute;
import software.amazon.awssdk.core.internal.interceptor.trait.RequestCompression;
import software.amazon.awssdk.regions.Region;
Expand Down Expand Up @@ -368,9 +366,15 @@ private List<PutMetricAlarmRequest> createTwoNewAlarms(String metricName) {
*/
@Test
public void testExceptionHandling() throws Exception {
Instant endTime = Instant.now();
try {
cloudwatch.getMetricStatistics(GetMetricStatisticsRequest.builder()
.namespace("fake-namespace").build());
.namespace("fake-namespace")
.startTime(endTime.minus(Duration.ofMinutes(5)))
.endTime(endTime)
.period(60)
.statistics(Statistic.AVERAGE)
.build());
fail("Expected an SdkServiceException, but wasn't thrown");
} catch (MissingRequiredParameterException e) {
// There is a strong contract on the value of these fields, and they should never change unexpectedly
Expand Down
Loading