feat(crt): add minTlsVersion option to CRT HTTP clients#7147
Open
zoewangg wants to merge 1 commit into
Open
Conversation
Add minTlsVersion(TlsVersion) on AwsCrtHttpClient.Builder and AwsCrtAsyncHttpClient.Builder so customers can enforce a minimum TLS protocol version for outbound connections. Fixes #5619
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #5619.
Customers using the AWS CRT HTTP client have no per-client way to require a minimum TLS protocol version.
Modifications
Adds a
minTlsVersion(TlsVersion)builder option on bothAwsCrtHttpClient.BuilderandAwsCrtAsyncHttpClient.Builder.@SdkPublicApienumsoftware.amazon.awssdk.http.crt.TlsVersionwith two values:TLS_1_3andSYSTEM_DEFAULT.postQuantumTlsEnabled(false)combined withminTlsVersion(TLS_1_3)fails atbuild()on platforms whereTLS_CIPHER_NON_PQ_DEFAULTis supported. The failure surfaces as the CRT-nativeIllegalStateExceptionfromTlsContextOptions#getNativeHandle("tlsCipherPreference and minTlsVersion are mutually exclusive"). The SDK does not wrap or replace this exception.TlsVersiontype Javadoc and the twominTlsVersion(...)builder-method Javadocs: Apple Secure Transport (the default macOS CRT TLS backend) does not support TLS 1.3. To useTlsVersion.TLS_1_3on macOS the customer must set env varAWS_CRT_USE_NON_FIPS_TLS_13to a non-empty value at process startup, which switches CRT to its s2n-tls backend (not FIPS-validated, no macOS Keychain integration). The SDK does not read or interpret this env var; the failure otherwise surfaces on the first request as a CRT-side error.Testing
Added new tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.Note on the
mvn installbox: only thehttp-clients/aws-crt-clientmodule was built locally (BUILD SUCCESS, 247 tests, 0 failures, 2 platform-skipped). A full-repomvn installwas not run.License