feat(athena): add conditional_merge_string parameter to to_iceberg#3361
Closed
bujjibabukatta wants to merge 2 commits into
Closed
feat(athena): add conditional_merge_string parameter to to_iceberg#3361bujjibabukatta wants to merge 2 commits into
bujjibabukatta wants to merge 2 commits into
Conversation
…g arg to _merge_iceberg and to_iceberg, enabling AND-predicate WHEN MATCHED clauses to prevent stale data overwrites. Resolves aws#3173.
bujjibabukatta
changed the title
kukushking
requested changes
Jun 10, 2026
kukushking
left a comment
kukushking
left a comment
Collaborator
There was a problem hiding this comment.
Test failures and a duplicate of #3201
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
conditional_merge_stringparameter towr.athena.to_iceberg, resolving #3173.When
merge_condition='conditional_update'and a SQL predicate is passed viaconditional_merge_string, the MERGE statement becomes:This prevents late-arriving records from overwriting more recent data.
Changes
conditional_updatetomerge_conditionLiteralconditional_merge_string: str | None = Nonetoto_iceberg,_merge_iceberg, and_validate_argsInvalidArgumentCombinationifconditional_updateis used without a predicate stringBackward compatibility
Fully backward compatible. Existing
'update'and'ignore'behaviour is unchanged.