fix: handle zero max_items_evaluated in DynamoDB read_items - #3417
Merged
Conversation
kukushking
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Fixes an issue in
awswrangler.dynamodb.read_itemswhere settingmax_items_evaluated=0was evaluated as a falsey truthiness check (if max_items_evaluated:andif limit:) rather than an explicitis not Nonecheck.This resulted in two bugs when
max_items_evaluated=0was provided:read_itemsraisedexceptions.InvalidArgumentCombinationstating that at least one read argument (likemax_items_evaluated) must be provided, even thoughmax_items_evaluatedwas explicitly passed.allow_full_scan=Truewas also provided alongsidemax_items_evaluated=0,max_items_evaluated=0was ignored and all items in the DynamoDB table were scanned/queried without any limit.Changes:
max_items_evaluatedargument validation inread_items()and_read_items()to checkis not None.max_items_evaluated=0, return an empty DataFrame (or empty list/iterator based onas_dataframeandchunkedarguments) directly without executing unnecessary network/scan requests or violating botocore parameter validation limits.InvalidArgumentValueifmax_items_evaluated < 0.tests/unit/test_moto.py.Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.