fix: pass delete_objects to get_botocore_valid_kwargs in _delete_objects - #3433
Open
hsusul wants to merge 1 commit into
Open
fix: pass delete_objects to get_botocore_valid_kwargs in _delete_objects#3433hsusul wants to merge 1 commit into
hsusul wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where
awswrangler.s3.delete_objectspassedfunction_name="list_objects_v2"instead offunction_name="delete_objects"toget_botocore_valid_kwargs().Root Cause
In
awswrangler/s3/_delete.py,_delete_objectscalled:Because of this:
delete_objectsparameters passed ins3_additional_kwargs(e.g.,BypassGovernanceRetention,MFA,ChecksumAlgorithm) were filtered out and silently ignored because they are not valid parameters forlist_objects_v2.list_objects_v2but invalid fordelete_objects(such asDelimiterorContinuationToken) were incorrectly preserved and passed tos3_client.delete_objects().Fix
Changed
function_name="list_objects_v2"tofunction_name="delete_objects"inawswrangler/s3/_delete.py.Testing
test_s3_delete_objects_additional_kwargsintests/unit/test_moto.pyverifying thatdelete_objects-specific parameters (BypassGovernanceRetention,RequestPayer) are retained and passed tos3_client.delete_objects(), while non-delete_objectsparameters (Delimiter) are filtered out.pytest tests/unit/test_moto.py,ruff check,ruff format --check, andmypy.