fix: preserve suffix filtering in _path2list when path is a list of S3 paths - #3434
Open
hsusul wants to merge 1 commit into
Open
fix: preserve suffix filtering in _path2list when path is a list of S3 paths#3434hsusul wants to merge 1 commit into
hsusul wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in
_path2list(awswrangler/s3/_list.py) where passing a list of S3 object paths (path=[...]) with asuffixfilter (e.g.,suffix=".parquet") ignored thesuffixfiltering wheneverignore_suffixwasNone(the default).Root Cause
In
_path2list, line 57 filters the inputpathlist according to_suffixintopaths.Line 58 then assigned
paths = path if _ignore_suffix is None else .... When_ignore_suffixisNone, it assignedpaths = path(the raw unfiltered list), discarding the filtered list produced on line 57.Solution
Change
paths = path if _ignore_suffix is None ...topaths = paths if _ignore_suffix is None ...so the result ofsuffixfiltering is preserved.Tests Added
Added
test_path2list_suffix_with_list_of_pathsintests/unit/test_moto.pycovering:suffixfiltering on a list of S3 paths withignore_suffix=None.suffixandignore_suffixwith a list of S3 paths.Validation Results
uv run pytest tests/unit/test_moto.py: 47 passed.uv run ruff format --check: Passed.uv run ruff check: Passed.git diff --check: Passed.moto.