Skip to content

telemetry(lambda): add telemetry definition for elevator - #1097

Closed
tobixlea wants to merge 4 commits into
aws:mainfrom
tobixlea:elevator-telemetry
Closed

telemetry(lambda): add telemetry definition for elevator#1097
tobixlea wants to merge 4 commits into
aws:mainfrom
tobixlea:elevator-telemetry

Conversation

@tobixlea

@tobixlea tobixlea commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

Problem

-Add telemetry definition for lambda elevator

Solution

run npm install and npm run validate as stated in Telemetry README.md

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tobixlea
tobixlea requested a review from a team as a code owner November 3, 2025 18:35
@seshubaws

Copy link
Copy Markdown

The rest of our metrics are in https://github.com/aws/aws-toolkit-common/blob/main/telemetry/definitions/commonDefinitions.json, think we can add this there so it's extensible to all Toolkits if/when in the future we get parity for them

@tobixlea

tobixlea commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

The rest of our metrics are in https://github.com/aws/aws-toolkit-common/blob/main/telemetry/definitions/commonDefinitions.json, think we can add this there so it's extensible to all Toolkits if/when in the future we get parity for them

Added metric to commonDefinitions.json along with the other sam metric definitions that were only in vscodeDefinitions.json

Comment thread telemetry/definitions/commonDefinitions.json
@laileni-aws laileni-aws reopened this Nov 11, 2025
@laileni-aws
laileni-aws enabled auto-merge (squash) November 11, 2025 19:34
@chungjac
chungjac changed the base branch from main to feature/test-release November 11, 2025 19:46
@chungjac
chungjac changed the base branch from feature/test-release to main November 11, 2025 19:47
@chungjac
chungjac disabled auto-merge November 11, 2025 19:50
@chungjac chungjac closed this Nov 11, 2025
@chungjac chungjac reopened this Nov 11, 2025
@tobixlea

Copy link
Copy Markdown
Contributor Author

Successful merge in separate PR: #1101
Closing this pul request

@tobixlea tobixlea closed this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants