-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config(chat): try opt in implicit @workspace context once if users are in treatment group #5302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vscode pr aws/aws-toolkit-vscode#6217 |
/retryBuilds |
leigaol
approved these changes
Jan 28, 2025
Will-ShaoHua
commented
Jan 28, 2025
@@ -48,6 +51,14 @@ class CodeWhispererSettings : PersistentStateComponent<CodeWhispererConfiguratio | |||
if (!hasEnabledProjectContextOnce()) { | |||
toggleEnabledProjectContextOnce(true) | |||
state.value[CodeWhispererConfigurationType.IsProjectContextEnabled] = value | |||
// todo: hack to bypass module dependency issue (codewhisperer -> shared), should pass [CodeWhispererShowSettingsAction] instead when it's resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will follow up in this wip pr #5304
rli
approved these changes
Jan 28, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-01-28.at.1.47.07.AM.mov
Description
Most users might have disabled workspace context due to previous sub-process performance issue, therefore #6098 experiment has too few datapoints.
As we've been actively working on fixes to improve the amazon q helper sub-process performance, the team decided to try turn on (only once) workspace context for a small fraction of all users (20%) to collect few more datapoints.
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.