Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amazonq): implement TextDocumentService message handler #5380

Open
wants to merge 25 commits into
base: feature/q-lsp
Choose a base branch
from

Conversation

samgst-amazon
Copy link
Contributor

initial framework for TextDocumentService message implementations

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Create a handler for relevant TextDocumentService listeners
implement didOpen and didClose message implementations

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

languageServer.textDocumentService.didOpen(
DidOpenTextDocumentParams().apply {
textDocument = TextDocumentItem().apply {
uri = file.url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url/uri logic should be consistent across all messages

Copy link

github-actions bot commented Feb 14, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@samgst-amazon samgst-amazon marked this pull request as ready for review February 24, 2025 23:54
@samgst-amazon samgst-amazon requested a review from a team as a code owner February 24, 2025 23:54
@samgst-amazon samgst-amazon marked this pull request as draft February 26, 2025 23:08
@samgst-amazon
Copy link
Contributor Author

currently needs to implement changes made to executeIfRunning from feature branch

@samgst-amazon samgst-amazon marked this pull request as ready for review February 28, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants