Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: UI test for feature availability in chat panel #5393
base: main
Are you sure you want to change the base?
ci: UI test for feature availability in chat panel #5393
Changes from 17 commits
4c09587
a9b2f15
f1583b1
d21fc4d
bcb83de
3b5fd0e
f3fbd5f
02b1388
1985edf
b9ae167
62c6526
0316bcf
7746823
2a87205
2f4899b
c5b0124
1241bca
c9e6533
2f87eaa
32813db
dc7f4e0
08ab782
a00e5eb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 5 in ui-tests-starter/build.gradle.kts
Unused import directive
Check notice on line 41 in ui-tests-starter/build.gradle.kts
Function or property has platform type
Check notice
Code scanning / QDJVMC
Function or property has platform type Note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isnt there a wait for index done or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a waitForIndicator() but that doesn't still doesn't add enough time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can do this
waitForIndicators(60.seconds)
but I have had mixed resultsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will address this in the next PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the first sleep but why the one here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one was mainly so that we could capture the exact output on the textbox cause otherwise it ends instantaneously. It doesnt need to be 20000 though, I'll try to make it shorter.
Check failure on line 21 in ui-tests-starter/tst-prep/PreAmazonQUiTest.kt
Unstable API Usage
Check failure
Code scanning / QDJVMC
Unstable API Usage Error
Check warning on line 26 in ui-tests-starter/tst-prep/PreAmazonQUiTest.kt
Unused symbol
Check warning
Code scanning / QDJVMC
Unused symbol Warning