feat(amazonq): expose lsp server capabilities to consumers of AmazonQLspService #5417
+14
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LspService
For certain capabilities, the client implementation needs to be aware of what resources the server is interested in.
In the case of `WorkspaceEdit`, we need to expose the filters returned by the server in the initialization handshake.
```json
"fileOperations": {
"didCreate": {
"filters": [
{
"pattern": {
"glob": "**/*.{ts,js,py,java}",
"matches": "file"
}
},
{
"pattern": {
"glob": "**/*",
"matches": "folder"
}
}
]
},
"didRename": {
"filters": [
{
"pattern": {
"glob": "**/*.{ts,js,py,java}",
"matches": "file"
}
},
{
"pattern": {
"glob": "**/*",
"matches": "folder"
}
}
]
},
"didDelete": {
"filters": [
{
"pattern": {
"glob": "**/*.{ts,js,py,java}",
"matches": "file"
}
},
{
"pattern": {
"glob": "**/*",
"matches": "folder"
}
}
]
}
}
```
rli
force-pushed
the
rli/expose-capabilities
branch
from
c8a3ee2 to
712dbcb
Compare
Qodana Community for JVM2 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -95,6 +94,8 @@ | |||
| @Service(Service.Level.PROJECT) | |||
| class AmazonQLspService(private val project: Project, private val cs: CoroutineScope) : Disposable { | |||
| private var instance: Deferred<AmazonQServerInstance> | |||
| val capabilities | |||
Check notice
Code scanning / QDJVMC
Function or property has platform type Note
| @@ -95,6 +94,8 @@ | |||
| @Service(Service.Level.PROJECT) | |||
| class AmazonQLspService(private val project: Project, private val cs: CoroutineScope) : Disposable { | |||
| private var instance: Deferred<AmazonQServerInstance> | |||
| val capabilities | |||
Check warning
Code scanning / QDJVMC
Unused symbol Warning
samgst-amazon
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain capabilities, the client implementation needs to be aware of what resources the server is interested in. In the case of
WorkspaceEdit, we need to expose the filters returned by the server in the initialization handshake.License
I confirm that my contribution is made under the terms of the Apache 2.0 license.