Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amazonq): Added progress indicator for lsp artifact download #5426

Merged
merged 7 commits into from
Feb 28, 2025

Conversation

LokeshDogga13
Copy link
Contributor

@LokeshDogga13 LokeshDogga13 commented Feb 28, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

image
  • fetchArtifact will return the artifact Path, if not available will throw LSP Exception

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LokeshDogga13 LokeshDogga13 requested a review from a team as a code owner February 28, 2025 21:19
.forEach { filename -> extractZipFile(downloadPath.resolve(filename), downloadPath) }
logger.info { "Successfully downloaded and moved LSP artifacts to $downloadPath" }
return
withBackgroundProgress(project, "Downloading & Extracting LSP artifacts...", cancellable = true) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localize

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link

github-actions bot commented Feb 28, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@LokeshDogga13 LokeshDogga13 enabled auto-merge (squash) February 28, 2025 22:32
@LokeshDogga13 LokeshDogga13 merged commit 0af95e3 into feature/q-lsp Feb 28, 2025
15 of 18 checks passed
@LokeshDogga13 LokeshDogga13 deleted the lodogga/downloadIndicator branch February 28, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants